TempleGold
TempleDAO
Foundry
25,000 USDC
View results
Previous Next
Submission Details
Severity: low
Valid

No TGLD recover mechanism in `DaiGoldAuction` when the auction ends without any bid

0xbrivan2

Vulnerability Details

In DaiGoldAuction contract, when an auction ends with no bids, the TGLD tokens are locked into the contract and can’t be recovered. recoverToken can not be used to recover TGLD tokens because it will revert when the auction epoch ends:

function recoverToken(
address token,
address to,
uint256 amount
) external override onlyElevatedAccess {
// ...
​
if (info.hasEnded()) { revert AuctionEnded(); }
​
// ...
}

There is no other way to recover the auction tokens. As a consequence, the TGLD tokens will be permanently locked in the contract

Impact

  • If the auction epoch ends without any bid, the TGLD tokens will be permanently locked in the contract

Tools Used

Manual Review

Recommendations

Consider adding a separate function that recovers TGLD tokens when the auction epoch ends without any bids. Similar to the one implemented in SpiceAuction::recoverAuctionTokenForZeroBidAuction

Updates

Lead Judging Commences

inallhonesty Lead Judge 12 months ago
Submission Judgement Published
Validated
Assigned finding tags:

Auctioned tokens cannot be recovered for epochs with empty bids in DaiGoldAuction

Appeal created

0xbrivan2 Submitter
12 months ago
inallhonesty Lead Judge
11 months ago
inallhonesty Lead Judge 11 months ago
Submission Judgement Published
Validated
Assigned finding tags:

Auctioned tokens cannot be recovered for epochs with empty bids in DaiGoldAuction

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.