TempleGold

TempleDAO
Foundry
25,000 USDC
View results
Submission Details
Severity: low
Invalid

add indexes to events

Summary

Some of events addresses doesnt have index. Add index to addresses in events inputs bellow.This change makes it easier and faster for clients like web3.js to search and filter events based on these addresses, despite slightly increasing gas costs

Proof

[event MigratorSet](https://github.com/Cyfrin/2024-07-templegold/blob/57a3e597e9199f9e9e0c26aab2123332eb19cc28/protocol/contracts/interfaces/templegold/ITempleGoldStaking.sol#L10)

[event Withdraw](https://github.com/Cyfrin/2024-07-templegold/blob/57a3e597e9199f9e9e0c26aab2123332eb19cc28/protocol/contracts/interfaces/templegold/ITempleGoldStaking.sol#L11)

[event StakingSet](https://github.com/Cyfrin/2024-07-templegold/blob/57a3e597e9199f9e9e0c26aab2123332eb19cc28/protocol/contracts/interfaces/templegold/ITempleGold.sol#L43)

[event EscrowSet](https://github.com/Cyfrin/2024-07-templegold/blob/57a3e597e9199f9e9e0c26aab2123332eb19cc28/protocol/contracts/interfaces/templegold/ITempleGold.sol#L44)

[event TeamGnosisSet](https://github.com/Cyfrin/2024-07-templegold/blob/57a3e597e9199f9e9e0c26aab2123332eb19cc28/protocol/contracts/interfaces/templegold/ITempleGold.sol#L45C5-L45C24)

Recommendations

Add index to addresses in event StakingSet(address staking); event EscrowSet(address escrow); event TeamGnosisSet(address gnosis);

event MigratorSet(address migrator);

and add index in toaddress in event Withdrawn(address indexed staker, address to, uint256 stakeIndex, uint256 amount);

Updates

Lead Judging Commences

inallhonesty Lead Judge 11 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.