The TempleGold::mint
will not revert if the mintAmount
doesn't meet the requirement to distribute, instead it simply returns. The people who is calling can not tell if the mint
is actually working as intended. This may cause issues in future integration.
In TempleGold::mint
, the minted amount mintAmount
is checked against canDistribute
, if the requirement doesn't meet, the function will simply return instead of reverting.
Thus, the caller can not directly tell if the mint
is actually working as intended. This may cause issues in future integration.
This could cause issues in future integration when the caller relies on the success distribution
to perform proceeding operations.
This could cause issues in future integration when the caller relies on the success distribution
to perform proceeding operations.
Manual
To mitigate this issue, it is recommended to return false
when the _canDistribute
fails.
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.