Summary

In the TempleGoldStaking::constructor, the stakingToken and rewardToken is initialized without ensuring that stakingToken != rewardToken. If stakingToken is set the same as rewardToken, this would cause accounting issues during staking.

Vulnerability Details

In the TempleGoldStaking::constructor, the stakingToken and rewardToken is initialized.

However, there is no check that stakingToken != rewardToken. If stakingToken is set the same as rewardToken, this would cause accounting issues during staking:

• User's staked tokens could be distributed as rewards.

Even though the stakingToken and rewardToken will be different per designed, it is still required to add this check to prevent the accounting issues.

Impact

If stakingToken is set the same as rewardToken, this would cause accounting issues during staking:

• User's staked tokens could be distributed as rewards.

Tools Used

Manual

Recommendations

Add a check to ensure stakingToken != rewardToken