There are two activation mode in SpiceAuction
for deciding the activation for an auction which are - AUCTION_TOKEN_BALANCE
and USER_FIRST_BID
.
The USER_FIRST_BID
involves enabling auction when user bids for other volatile token, but still the startAuction
function follows the AUCTION_TOKEN_BALANCE
in which auction is enabled and awaiting start after cooldown is over.
The vulnerability is present in the startAuction
function where for the config corresponding to the auction to be started, it performs activation by AUCTION_TOKEN_BALANCE
even if in the config USER_FIRST_BID
is set.
No matter what activation mode it performs the same set of operations, i.e., Auction is enabled and is awaiting start if there is enough auction token, otherwise it revert.
Thus, even for USER_FIRST_BID
as activation mode it performs the same set of operations that are performed in AUCTION_TOKEN_BALANCE
.
Auction is activated according to AUCTION_TOKEN_BALANCE
activation mode even if activation mode is set as USER_FIRST_BID
.
Manual Review
Consider updating startAuction
function and consider USER_FIRST_BID
activation mode, for which auction is enabled when user bids for other volatile token.
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.