Submission Details
Severity:
we need to implement access control for distributeGold() and check for call to mint()
Unchecked External Call to mint Function + we need access controll
The call to templeGold.mint() in the _distributeGold function is not checked. If templeGold.mint() fails or reverts, the transaction will silently fail, which could lead to unexpected behavior.
Anyone can call the distributeGold()
/**
* @notice Mint and distribute TGOLD
*/
//@audit add access control
function distributeGold() external {
_distributeGold();
}
//@audit add check for success of the tx
function _distributeGold() private {
/// @dev no op silent fail if nothing to distribute
templeGold.mint();
}
Fix: Ensure to handle the success or failure of the mint function call properly.
function _distributeGold() private {
// Check if minting succeeds
try templeGold.mint() {
// Minting successful
} catch {
// Handle minting failure
revert CommonEventsAndErrors.MintFailed();
}
}
Prize pool breakdown
Total prize
25,000 USDC
nSLOC
99825 USDC / LOC
20,000 USDC
2,500 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.