When a user bids DaiGoldAuction
the auction uses a fee-on-transfer token, incorrect accounting is made and the user is accounted for with more tokens than he deposited. A check for the auctions's balance before and after is not done and the amount that comes from the input is directly added to the depositor's balance as well as to totalBidTokenAmount
Imagine the auction starts with a fee-on-transfer token and Alice bids 100 tokens.
The auction contract will receive 98 because of the fee, but it will account for 100 tokens.
At the end of the auction, Alice will receive more gold than she deserves
This leads to incorrect accounting and users will claim more TempleGold
than they should
Manual review
If you want to allow fee-on-transfer tokens use the bellow update
Check the balance of the contract before and after the transfer of the tokens as done in the SpiceAuction.sol
If you don't want to allow fee-on-transfer tokens add the following check:
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.