Summary

rewardAmount equals to zero check is missing in the TempleGoldStaking contract.

Vulnerability Details

• https://github.com/Cyfrin/2024-07-templegold/blob/main/protocol/contracts/templegold/TempleGoldStaking.sol#L190

There is no check of zero value of rewardAmount though in the comment it is mentioned that revert if next reward is 0 .

Impact

It does not revert when the next reward amount is 0.

Tools Used

Manual Review

Recommendations

Put the proper check in the line
if ( rewardAmount == 0 ||rewardAmount < rewardDuration ) { revert CommonEventsAndErrors.ExpectedNonZero(); }