TempleGold

Summary

Incorrect implementation of _debit in function send

Vulnerability Details

As can be seen in the layerzero docs, there is no msg.sender in _debit. there is no need to add msg.sender. This will lead to error in the code execution.

-debit from the implementation should take 3 arguments but the code below takes 4. msg.sender should not be a part of the arguments or params. The code will not execute as intended. This is an error.

https://github.com/Cyfrin/2024-07-templegold/blob/57a3e597e9199f9e9e0c26aab2123332eb19cc28/protocol/contracts/templegold/TempleGold.sol#L295C9-L300C11

https://docs.layerzero.network/v2/developers/evm/oft/quickstart#adding-send-logic

Impact

Incorrect implementation leads to unintended consequences or error in execution.

Tools Used

Manual Review

Recommendations