TempleGold

TempleDAO
Foundry
25,000 USDC
View results
Submission Details
Severity: medium
Invalid

Missing Address Validation in Setter Functions

Summary

The TempleGoldAdmin contract's setter functions (setStaking, setEscrow, and setTeamGnosis) do not validate the input addresses to ensure they are valid contract addresses of the corresponding types. Setting an invalid address could lead to unexpected behavior and potential vulnerabilities in the system.

Vulnerability Details

The setter functions in TempleGoldAdmin directly update the state variables (staking, escrow, and teamGnosis) with the provided addresses without checking if these addresses are valid contracts or if they implement the required interfaces (ITempleGoldStaking, IDaiGoldAuction). If an incorrect or invalid address is set, subsequent interactions with these contracts could fail, leading to errors or unexpected behavior.

Impact

If an invalid address is set for a contract, any attempt to interact with that contract from TempleGoldAdmin or TempleGold could fail, potentially disrupting the functionality of the system.

Tools Used

Mnual Review

Recommendations

Ensure that the provided address is not the zero address (address(0)).

Updates

Lead Judging Commences

inallhonesty Lead Judge 12 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.