TempleGold
TempleDAO
Foundry
25,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

Overwriting of existing auctions in `SpiceAuctionFactory`

0xtheblackpanther

GitHub

https://github.com/Cyfrin/2024-07-templegold/blob/6c3980a0486c01114d0ef1281df188b6c01991e6/protocol/contracts/templegold/SpiceAuctionFactory.sol#L39-L48

Summary

The SpiceAuctionFactory contract allows overwriting of existing auctions in the deployedAuctions mapping without any checks to facilitate migrations.

Impact

Existing auction contracts could be accidentally or maliciously replaced, leading to loss of auction data.

Recommendation

Emit warnings when overwriting existing auctions to ensure transparency and mitigate the risk of accidental overwrites.

function createAuction(address spiceToken, string memory name) external override onlyElevatedAccess returns (address) {
if (spiceToken == address(0)) { revert CommonEventsAndErrors.InvalidAddress(); }
if (spiceToken == templeGold) { revert CommonEventsAndErrors.InvalidParam(); }
SpiceAuction spiceAuction = new SpiceAuction(templeGold, spiceToken, daoExecutor, name);
bytes32 pairId = _getPairHash(spiceToken);
if (deployedAuctions[pairId] != address(0)) {
emit AuctionOverwriteWarning(pairId, deployedAuctions[pairId]); // Emit warning for overwrite
}
deployedAuctions[pairId] = address(spiceAuction);
emit AuctionCreated(pairId, address(spiceAuction));
return address(spiceAuction);
}

Events to Emit

event AuctionOverwriteWarning(bytes32 indexed pairId, address oldAuction);

This approach maintains the ability to overwrite auctions for migration purposes while providing a mechanism to track and log such actions to prevent accidental overwrites and improve transparency.

Updates

Lead Judging Commences

inallhonesty Lead Judge 11 months ago
Submission Judgement Published
Invalidated
Reason: Design choice
Assigned finding tags:

Overwriting of existing auctions in `SpiceAuctionFactory`

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.