TempleGold

Summary

In TempleGoldStaking, when the totalSupply becomes large, the reward per token will get down. Users will have less incentive to claim dust reward, leaving the dust reward amount stuck in the staking contract. Especially when the user's reward needs to be claimed by each index, causing unnecessary gas consumptions and costs.

Vulnerability Details

In _rewardPerToken, the result is calculated based on totalSupply:

If the totalSupply is large, the reward per token will get down.

Thus, users with small stakes will have less incentive to claim dust reward, leaving the dust reward amount stuck in the staking contract forever. Especially when the user's reward needs to be claimed by each index, causing unnecessary gas consumptions and costs.

Impact

Small dust reward will never be claimed by users. And users are discouraged from getting their reward.

Tools Used

Manual

Recommendations

It is recommended to revise the design of staking using multiple indexes.