TempleGold

Summary

Some return values are being wrongly casted.

Vulnerability Details

As you can see:

• lastUpdateTime has been wrongfully cast into a uint40 here.

• _lastTimeRewardApplicable function output value has been capped at uint256 but here it's being incorrectly converted to uint40.

Note: All of these values are timestamp values and even a uint40 value is approx~ 1 trillion seconds which is almost 31709 years so there is no impact on funds, I am simply putting this in low due to the wrong practices that are being followed.

Impact

Although there are no funds at risk but its still wrong practice to do such type of casting.

Tools Used

Manual review

Recommendations

Either make the timestamp value capped at uint40 or uint256.