TempleGold

TempleDAO
Foundry
25,000 USDC
View results
Submission Details
Severity: low
Invalid

No need to revert if current auction is active when ```setAuctionConfig``` is invoked

Summary

In SpiceAuction::setAuctionConfig, it checks if current auction is active and if so reverts because, in accordance with the docs, it cannot set config for ongoing auctions. However, setAuctionConfig sets the configuration for the next epoch so it should not revert.

Vulnerability Details

When setAuctionConfig is invoked, the configuration for the next epoch (i.e. auctionConfigs[_currentEpochId + 1] is set). There is no reason to revert this function if the current auction is active.

Impact

Reverts a function call impeding setting the next epoch auction configuration when there is no need for it.

Tools Used

Manual review

Recommendations

No need to revert if current auction is active.

Updates

Lead Judging Commences

inallhonesty Lead Judge 11 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.