TempleGold
TempleDAO
Foundry
25,000 USDC
View results
Previous Next
Submission Details
Severity: low
Valid

0 bid auctions will leave auction tokens stuck inside the contract

pyro

Summary

0 bid auctions will leave auction tokens stuck inside the contract.

Vulnerability Details

There is a chance, even if small, that DaiGoldAuction will have an auction with 0 bids. This can happen for various reasons, such as the auction being too small, the system being new and not well-known, or other factors.

If an auction ends with 0 bids, the auction tokens will remain stuck inside the contract. Even recoverToken won't be able to rescue them after the auction has ended.

if (info.startTime == 0) { revert InvalidOperation(); }
if (info.isActive()) { revert AuctionActive(); }
if (info.hasEnded()) { revert AuctionEnded(); }

Impact

Auction tokens will be permanently stuck inside DaiGoldAuction.

Tools Used

Manual review

Recommendations

Implement a feature to recover auction tokens from 0 bid auctions, similar to SpiceAuction's recoverAuctionTokenForZeroBidAuction.

Updates

Lead Judging Commences

inallhonesty Lead Judge
11 months ago
inallhonesty Lead Judge 11 months ago
Submission Judgement Published
Validated
Assigned finding tags:

Auctioned tokens cannot be recovered for epochs with empty bids in DaiGoldAuction

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.