First Flight #20: The Predicter

Summary

he getPlayerScore function does not verify if the actual result of the match is finalized before using it for score calculation. This can lead to incorrect score calculations if pending results are included.

Vulnerability Details

No Check for Finalized Results: The function does not check if the actual match result is finalized (i.e., not Result.Pending). This oversight can cause the score calculation to include incomplete or pending match results, leading to inaccurate scores.

Impact

Inaccurate Score Calculations: Including pending match results in the score calculation can lead to incorrect player scores, affecting the integrity and fairness of the scoring process.

Tools Used

Manual code review

Recommendations
Add Check for Finalized Results: Ensure that the actual match result is finalized before using it for score calculation. This maintains the integrity and fairness of the scoring process.