Submission Details
Severity:
Functions does not emit events for better tracking.
Summary
Functions that change the state of the contract should emit events for better tracking.
Impact Lack of transparency and difficulty in tracking state changes.
Tools Used Manual Review
Recommendations
Emit an event after a successful prediction.
function makePrediction(
uint256 matchNumber,
ScoreBoard.Result prediction
) public payable {
if (msg.value != predictionFee) {
revert ThePredicter__IncorrectPredictionFee();
}
if (block.timestamp > START_TIME + matchNumber * 86400 - 3600) {
revert ThePredicter__PredictionsAreClosed();
}
require(playersStatus[msg.sender] == Status.Approved, "Player not authorized to predict"); // Added authorization check
scoreBoard.confirmPredictionPayment(msg.sender, matchNumber);
scoreBoard.setPrediction(msg.sender, matchNumber, prediction);
emit PredictionMade(msg.sender, matchNumber, prediction); // Event emission added for transparency
}
event PredictionMade(address indexed player, uint256 matchNumber, ScoreBoard.Result prediction);
Rewards breakdown
nSLOC
191This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.