First Flight #20: The Predicter

Summary

The ScoreBoard::isEligibleForReward function doesnt implement the requirement for players been eligible to get reward correctly, this would short change some players in the protocol that has made atleast one prediction. The condition to be eligible for reward is that the player MUST atlease predict a game and have a positive score point. In the ScoreBoard::isEligibleForReward function this condition is not applied. Players that have made atleast one prediction are not eligible for reward which is NOT in line with the protocol's documentation. Players that have made atleast one prediction are eligible for reward.

Vulnerability Details

playersPredictions[player].predictionsCount > 1 This code line makes it impossible for players that have made atleast one prediction NOT to be eligible for reward.

Impact

The ScoreBoard::isEligibleForReward function not been implemented in the protocol shortchanges the players that make atleast one prediction, this denies players that have made atleast one prediction of their rewards

Tools Used

Manuel Review

Recommendations

The `ScoreBoard::isEligibleForReward` function should be implemented according to documentation of the protocol, players that have predicted atleast one game should be eligible for reward.