Submission Details
Severity:
contract can be emptied due to a reentrancy issue in `ThePredicter::cancelRegistration`
[H-02] contract can be emptied due to a reentrancy issue in ThePredicter::cancelRegistration
Vulnerability Details
the cancelRegistration function does not follow CEI when calling an external account. this can be used to empty the contract using a smart contract account.
function cancelRegistration() public {
if (playersStatus[msg.sender] == Status.Pending) {
@> (bool success, ) = msg.sender.call{value: entranceFee}("");
require(success, "Failed to withdraw");
@> playersStatus[msg.sender] = Status.Canceled;
return;
}
revert ThePredicter__NotEligibleForWithdraw();
}
Impact
a malicous user can empty the contract using a smartContract Account,
Tools Used
Manual Reivew
Recommendations
Consider following CEI, Checks Effects Interactions:
function cancelRegistration() public {
if (playersStatus[msg.sender] == Status.Pending) {
+ playersStatus[msg.sender] = Status.Canceled;
(bool success, ) = msg.sender.call{value: entranceFee}("");
require(success, "Failed to withdraw");
- playersStatus[msg.sender] = Status.Canceled;
return;
}
revert ThePredicter__NotEligibleForWithdraw();
}
Updates
Lead Judging Commences
NightHawK 11 months ago
Submission Judgement Published Assigned finding tags:
Reentrancy in cancelRegistration
Reentrancy of ThePredicter::cancelRegistration allows a maliciour user to drain all funds.
Rewards breakdown
nSLOC
191This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.