Submission Details
Severity:
Player can pay multiple times in `ThePredicter::register` when not supposed to
Summary
Player can pay multiple times in ThePredicter::register when not supposed to. If the player is approved, the player can call ThePredicter::register and pay again which leads to the player getting status PENDING again.
Vulnerability Details
Even if this is not necessarily a security hole, the player can lose money by calling this function by mistake. Not to mention, the player gets its status set to Pending again even when added/approved as a player.
Impact
Low
Tools Used
Code inspection
Recommendations
Add a check so Approved players cannot register again:
- if (playersStatus[msg.sender] == Status.Pending) {
+ if (playersStatus[msg.sender] == Status.Pending || playersStatus[msg.sender] == Status.Approved) {
revert ThePredicter__CannotParticipateTwice();
}
Rewards breakdown
nSLOC
191This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.