Submission Details
Severity:
`ScoreBoard::isEligibleForReward` requires more than 1 prediction, but documentation says only 1 required
Summary
The documentation says:
"Players can receive an amount from the prize fund only if their total number of points is a positive number and if they had paid at least one prediction fee."
But ScoreBoard::isEligibleForRewardrequires the user to have more than 1 prediction.
Recommendations
function isEligibleForReward(address player) public view returns (bool) {
return
results[NUM_MATCHES - 1] != Result.Pending &&
- playersPredictions[player].predictionsCount > 1;
+ playersPredictions[player].predictionsCount >= 1;
}
Updates
Lead Judging Commences
NightHawK about 1 year ago
Submission Judgement Published Assigned finding tags:
The eligibility criteria is wrong
Players with only one prediction cannot withdraw.
Rewards breakdown
nSLOC
191This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.