Submission Details
Severity:
Lack of a zero address check in `ThePredicter::setThePredicter`
Summary
The function ThePredicter::setThePredicter that sets the predicter, lacks a check for 0 address inputs.
Vulnerability Details
The zero address commonly represents an uninitialized or invalid address in Ethereum.
function setThePredicter(address _thePredicter) public onlyOwner {
thePredicter = _thePredicter;
}
Impact
Allowing the setting of a zero address as the predictor would effectively render any interactions with the predictor address impossible, leading to a loss of functionality within the contract.
Tools Used
Manual review
Recommendations
Consider adding a 'require' statement to check that the address is different from address(0). Here is the recommended modification:
function setThePredicter(address _thePredicter) public onlyOwner {
+ require(_thePredicter != address(0), "Zero address cannot be set as the predictor.");
thePredicter = _thePredicter;
}
Rewards breakdown
nSLOC
191This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.