First Flight #20: The Predicter

Summary

The setPrediction() function currently lacks any role-based access control. This oversight allows any user to call the function and potentially alter predictions.

Impact

Without proper access control, unauthorized players can modify predictions made by other players. This could enable malicious actors to change predictions to the Pending result, leading to incorrect outcomes and undermining the fairness of the game.

Tools Used

Manual review and testing

Recommendations

Restrict access to the setPrediction() function by applying an onlyThePredicter() modifier. This will ensure that only authorized users can call this function.

This modification ensures that only designated roles, likely the contract owner or a trusted entity, can set or modify player predictions. This measure protects the integrity of the game and prevents unauthorized manipulation of predictions.