Submission Details
Severity:
Redundant timestamp check in `ThePredicter::makePrediction` wastes gas, as `ScoreBoard::setPrediction` checks it as well
Description:
Since setPrediction already includes the time check, it is redundant to have the same check in makePrediction. We can simplify makePrediction by removing the redundant check.
function setPrediction(address player, uint256 matchNumber, Result result) public {
// @written-mid Incorrect time calculation leads to being unable to set predictions for round 0
if (block.timestamp <= START_TIME + matchNumber * 68400 - 68400) {
playersPredictions[player].predictions[matchNumber] = result;
}
Impact:
This additional check makes the transaction more expensive than it should be.
Recommended Mitigation:
Remove the following from ThePredicter::makePrediction:
function makePrediction(uint256 matchNumber, ScoreBoard.Result prediction) public payable {
if (msg.value != predictionFee) {
revert ThePredicter__IncorrectPredictionFee();
}
- if (block.timestamp > START_TIME + matchNumber * 68400 - 68400) {
- revert ThePredicter__PredictionsAreClosed();
- }
scoreBoard.confirmPredictionPayment(msg.sender, matchNumber);
scoreBoard.setPrediction(msg.sender, matchNumber, prediction);
}
Rewards breakdown
nSLOC
191This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.