Submission Details
Severity:
Missing Address Zero Check At Constructor
Relevant GitHub Link
Summary
The constructor does not verify that the _scoreBoard address is a non-zero address. If a zero address is passed, it could lead to undefined behavior and potential security risks when interacting with the ScoreBoard contract.
Impact
If the scoreBoard address is set to the zero address, any function calls to the ScoreBoard contract will fail, resulting in the contract not functioning as intended. This can cause the entire ThePredicter contract to be unusable.
Tools Used
Manual Reading
Recommendations
Add a check in the constructor to ensure that the _scoreBoard address is not the zero address
constructor(
address _scoreBoard,
uint256 _entranceFee,
uint256 _predictionFee
) {
if (_scoreBoard == address(0)) {
revert ThePredicter__InvalidScoreBoardAddress();
}
organizer = msg.sender;
scoreBoard = ScoreBoard(_scoreBoard);
entranceFee = _entranceFee;
predictionFee = _predictionFee;
}
Rewards breakdown
nSLOC
191This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.