Submission Details
Severity:
Duplicate condition for checking if a user can make a prediction due to datetime restrictions
Relevant GitHub Links
https://github.com/Cyfrin/2024-07-the-predicter/blob/main/src/ThePredicter.sol#L93
Summary
The condition in ThePredicter::makePrediction can be removed because there is a function call to ScoreBoard::setPrediction where the same condition is checked. Removing this duplicate condition doesn't change the code logic but saves gas by checking the datetime restriction once instead of twice.
Impact
The code is more gas expensive to execute when checking datetime restrictions twice instead of once.
Recommendations
Remove the datetime restriction condition in the ThePredicter::makePrediction function.
function makePrediction(
uint256 matchNumber,
ScoreBoard.Result prediction
) public payable {
if (msg.value != predictionFee) {
revert ThePredicter__IncorrectPredictionFee();
}
- if (block.timestamp > START_TIME + matchNumber * 68400 - 68400) {
- revert ThePredicter__PredictionsAreClosed();
- }
scoreBoard.confirmPredictionPayment(msg.sender, matchNumber);
scoreBoard.setPrediction(msg.sender, matchNumber, prediction);
}
Rewards breakdown
nSLOC
191This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.