Zaros Part 1
Zaros
DeFiFoundry
60,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

The BaseKeeper::setForwarder function is external and changes the state of the blockchain, it is recommended to emit an event.

0xcodex

Summary

The function "BaseKeeper::setForwarder" is an external function that changes the state of the blockchain and does not emit an event when it is called.

Vulnerability Details

The function "BaseKeeper::setForwarder" is an external function that alters the blockchain state and includes critical operations. If it does not emit an event, tracking the frequency of keeper forwarder updates will be impossible. Emitting an event is essential for maintaining transparency and ensuring accurate monitoring of these updates.

Impact

No real impact on the contract, it might just be impossible to track updates of the keeper forwarder.

Tools Used

Manual Review

Recommendations

The "BaseKeeper::setForwarder" function is an external function that modifies the blockchain's state. Given the significance of the operations it performs, it is advisable to log these changes. Therefore, it is recommended that this function emit an event each time it is called, to ensure proper tracking and transparency.

+ event ForwarderIsUpdated(address forwarder);
​
function setForwarder(address forwarder) external onlyOwner {
BaseKeeperStorage storage self = _getBaseKeeperStorage();
self.forwarder = forwarder;
​
+ emit ForwarderIsUpdated(msg.sender);
}
Updates

Lead Judging Commences

inallhonesty Lead Judge
about 1 year ago
inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.