Zaros Part 1

Summary

Incorrect function modifier used leads to wrong data returned. There are other functions with the same root cause of using pure modifier instead of view

Vulnerability Details

this function is marked as pure, but it's actually reading from and potentially writing to storage. Here are the issues:

1. pure Function Modifier: The pure modifier is used for functions that don't read from or modify the contract's state. However, this function is clearly interacting with storage by setting the slot of a storage variable.

2. Storage Access in a Pure Function: The function is returning a storage reference (Data storage customReferralConfigurationTestnet), which implies reading from or potentially writing to storage. This operation cannot be performed in a pure function.

Impact

Because the function is marked as pure, it will compile but won't actually load or return the correct data from storage. Instead, it might return uninitialized or incorrect data.

Tools Used

Manual Review

Recommendations

change the function modifier from pure to view