DeFiFoundry
60,000 USDC
View results
Submission Details
Severity: low
Invalid

Possible DOS in BuyCreditLimit Due to Unbounded Array

Description

The configureCollateralLiquidationPriority and configureLiquidators functions in GlobalConfigurationBranch library emits events with unbounded arrays, potentially causing out-of-gas errors.

Code Snippet

File: src/perpetuals/branches/GlobalConfigurationBranch.sol
function configureCollateralLiquidationPriority(address[] calldata collateralTypes) external onlyOwner {
/// ... existing code ...
emit LogConfigureCollateralLiquidationPriority(msg.sender, collateralTypes);
}
function configureLiquidators(address[] calldata liquidators, bool[] calldata enable) external onlyOwner {
/// ... existing code ...
emit LogConfigureLiquidators(msg.sender, liquidators, enable);
}

Recommendations

Implement a maximum limit for the number of elements in the collateralTypes and liquidators arrays.

Updates

Lead Judging Commences

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Lack of quality

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.