Zaros Part 1

Summary

If a user's trading account becomes liquidatable but has a positive PnL (profit and loss), the user will not receive the rewards generated from their position.

Vulnerability Details

In scenarios where a trading account becomes liquidatable but still has a positive PnL, the current logic does not account for transferring the rewards to the user. This oversight results in users losing their earned rewards despite having a profitable position.

Impact

Users will lose all rewards generated by their positions if their accounts become liquidatable, leading to financial losses and potential dissatisfaction with the platform.

Tools Used

Manual review

Recommendations

Implement logic to ensure that users receive the appropriate rewards during liquidation. This could involve:

• Checking for positive PnL during the liquidation process.

• Transferring the corresponding rewards to the user's account before finalizing the liquidation.

By addressing this issue, the platform can ensure fair treatment of users and maintain trust in its trading and reward mechanisms.