Zaros Part 1

Summary

Several initialization functions are vulnerable to front-running attacks, which could lead to malicious actors improperly initializing the contracts with harmful values.

Vulnerability Details

Description

The initialize function in the UpgradeBranch.sol, MarketOrderKeeper.sol and LiquidationKeeper.sol contracts can be front-run, allowing an attacker to initialize the contract with malicious values.

UpgradeBranch.sol

Code Snippet

MarketOrderKeeper.sol

Code Snippet

LiquidationKeeper.sol

Code Snippet

Impact

• UpgradeBranch: An attacker could front-run the initialization and set their own address as the owner, gaining control over the contract.

• MarketOrderKeeper: An attacker could front-run the initialization and set their own address as the owner, gaining control over the contract and also can set invalid or malicious values for the parameters, disrupting the contract's functionality.

• LiquidationKeeper: An attacker could front-run the initialization and set their own address as the owner, gaining control over the contract and also can set an invalid or malicious address for the perpsEngine parameter, causing the contract to malfunction.

Tools Used

• manual review

Recommendations

• ** Factory Pattern**: Consider using a factory contract to deploy and initialize contracts in one transaction, preventing front-running.

• Deployment Scripts: Ensure deployment scripts have robust protections against front-running attacks.