Submission Details
Severity:
`depositMargin` enforces marginCollateralConfiguration.depositCap BUT does not scale up the `depositCap` to 18 decimals before comparing it to scaled up `amountX18`
Vulnerability Details
All collateral tokens have an associated depositCap
The total deposits can never exceed this depositCap, it is enforced in depositMargin as follows
_requireEnoughDepositCap(collateralType, amountX18, depositCapX18, totalCollateralDepositedX18);
The issue is that amountX18 and totalCollateralDepositedX18 are values scaled up to 18 decimals if the collateral token has < 18 decimals BUT depositCapX18 is never scaled up.
Impact
depositCap will be easily surpassed for tokens with < 18 decimals
Tools Used
Manual Review
Recommendations
Scale up depositCapX18 by the appropriate number of decimals
Updates
Prize pool breakdown
Total prize
60,000 USDC
nSLOC
2,87821
USDC / LOC
50,000 USDC
5,500 USDC
4,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.