DeFiFoundry
60,000 USDC
View results
Submission Details
Severity: low
Invalid

Remove the commented code or improve the comments.

Summary

commented code should be removed from the MarketOrderKeeper.

Vulnerability Details

MarketOrderKeepercontains some commented code of a function. Either it should be removed or there should be some comments mentioned at the top of it stating the reasons for keeping it.

https://github.com/Cyfrin/2024-07-zaros/blob/d687fe96bb7ace8652778797052a38763fbcbb1b/src/external/chainlink/keepers/market-order/MarketOrderKeeper.sol#L90C1-L99C9

Impact

Codebase looks unprofessional

Tools Used

  • Manual Review

Recommendations

Remove the commented code or add better comments.

Updates

Lead Judging Commences

inallhonesty Lead Judge 11 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.