Zaros Part 1

Summary

Zaros has implemented the logic responsible for keepers to fulfill market orders in the src\external\chainlink\keepers\market-order\MarketOrderKeeper.sol contract.

These keepers execute the performUpkeep() function which in turn triggers the perpsEngine.fillMarketOrder() function which logic can be found in SettlementBranch

Vulnerability Details

The issue is that there exists no logic in the repository that is responsible for triggering perpsEngine.fillOffchainOrders() and fulfill off-chain orders.

Impact

Off-chain orders can't be fulfilled by keepers making the off-chain orders functionnality unable to be used.

Tools Used

Manual review

Recommendations

Just like market orders, a new keeper contract must be implemented in src\external\chainlink\keepers\ that would take care of fulfilling off-chain orders