Zaros Part 1

Summary

there could be a DOS of all positions by the configureSystemParameters function

Vulnerability Details

in src/perpetuals/branches/GlobalConfigurationBranch.sol Line 330 if marketOrderMinLifetime is set to maxUint256 (or a high number) all existing positions are stuck.

This happens beacuse of the minmum lifetime of a position can retroactivly change to effect existing positions and not only new ones, so you can retroactivly make positions look "new" and thus stack until the time passed (might be maxuint256).

Impact

DOS to all positions

Tools Used

None

Recommendations

Make it so every position has its own MinLifetime so if it updates it only effect new positions