Zaros Part 1

Summary

if the collateral count is to big there i s no way to check if a liqudation is needed because of out of gas

Vulnerability Details

if an account adds all valid collaterals as they change the account not removing anyone of them, after enough uniqe collaterals were an option this account is unliquidatable.

you can add a collateral without chacking the conditions with the depositMargin function in src/perpetuals/branches/TradingAccountBranch.sol

Impact

DOS to liquidations

Tools Used

None

Recommendation

only go over existing collaterals and not privious ones