DeFiFoundry
60,000 USDC
View results
Submission Details
Severity: medium
Invalid

Missing 2 fields in `DataStreamsStrategy` Struct Definition in `SettlementConfiguration`

Summary

The DataStreamsStrategy struct in the SettlementConfiguration library has two variables, feedLabel and queryLabel, mentioned in the NatSpec comments but not defined in the struct itself. This discrepancy can lead to confusion and potential implementation issues.

Vulnerability Details

The DataStreamsStrategy struct is missing the feedLabel and queryLabel fields, which are referenced in the NatSpec comments but not actually included in the struct definition. This inconsistency can cause confusion for developers and may lead to errors if these fields are expected to be present in the struct.

/// @notice Data structure used by CL Data Streams powered orders.
/// @param chainlinkVerifier The Chainlink Verifier contract address.
/// @param streamId The Chainlink Data Streams stream id.
/// @param feedLabel The Chainlink Data Streams feed label.
/// @param queryLabel The Chainlink Data Streams query label.
struct DataStreamsStrategy {
IVerifierProxy chainlinkVerifier;
bytes32 streamId;
}

Impact

The absence of feedLabel and queryLabel in the DataStreamsStrategy struct can lead to confusion for developers who rely on the NatSpec comments. Potential implementation issues if the missing fields are assumed to exist elsewhere in the codebase.

Tools Used

Manual Review

Recommendations

To resolve this issue, add the feedLabel and queryLabel fields to the DataStreamsStrategy struct. This ensures that the struct aligns with the NatSpec comments and any potential usage scenarios.

Updates

Lead Judging Commences

inallhonesty Lead Judge
about 1 year ago
inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.