Zaros Part 1
Zaros
DeFiFoundry
60,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

Redundant zero check for initialMarginRateX18

0xleadwizard

Summary

The zero check for initialMarginRateX18 is unnecessary and can be omitted

https://github.com/Cyfrin/2024-07-zaros/blob/main/src/perpetuals/branches/GlobalConfigurationBranch.sol#L504-L506

if (params.initialMarginRateX18 == 0) {revert Errors.ZeroInput("initialMarginRateX18");}

The combination of the following checks makes it redundant

  1. https://github.com/Cyfrin/2024-07-zaros/blob/main/src/perpetuals/branches/GlobalConfigurationBranch.sol#L495-L497

  2. https://github.com/Cyfrin/2024-07-zaros/blob/main/src/perpetuals/branches/GlobalConfigurationBranch.sol#L507-L509

if (params.maintenanceMarginRateX18 == 0) {revert Errors.ZeroInput("maintenanceMarginRateX18");}
​
if (params.initialMarginRateX18 <= params.maintenanceMarginRateX18) {
revert Errors.InitialMarginRateLessOrEqualThanMaintenanceMarginRate();
}

Updates

Lead Judging Commences

inallhonesty Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!