Submission Details
Severity:
depositMargin function visibility should be external
Summary
https://github.com/Cyfrin/2024-07-zaros/blob/main/src/perpetuals/branches/TradingAccountBranch.sol#L317
function depositMargin(uint128 tradingAccountId, address collateralType, uint256 amount) public virtual
depositMargin is not called by TradingAccountBranch itself, there is no need for public visibility
Prize pool breakdown
Total prize
60,000 USDC
nSLOC
2,87821
USDC / LOC
50,000 USDC
5,500 USDC
4,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.