Submission Details
Severity:
checkLog is wrong implemented in "MarketOrderKeeper"
Summary
In checklog we are using revert instead of return.
Vulnerability Details
function checkLog(
AutomationLog calldata log,
bytes calldata
)
external
view
override
returns (bool, bytes memory)
{
uint128 tradingAccountId = uint256(log.topics[LOG_CREATE_MARKET_ORDER_ACCOUNT_ID_INDEX]).toUint128();
(MarketOrder.Data memory marketOrder) = abi.decode(log.data, (MarketOrder.Data));
MarketOrderKeeperStorage storage self = _getMarketOrderKeeperStorage();
string[] memory streams = new string[](1);
streams[0] = self.streamId;
uint256 settlementTimestamp = marketOrder.timestamp;
bytes memory extraData = abi.encode(tradingAccountId);
@> revert StreamsLookup(
DATA_STREAMS_FEED_LABEL, streams, DATA_STREAMS_QUERY_LABEL, settlementTimestamp, extraData
);
}
Impact
checklog will always revert
Tools Used
Recommendations
return StreamsLookup(
DATA_STREAMS_FEED_LABEL, streams, DATA_STREAMS_QUERY_LABEL, settlementTimestamp, extraData
);
Updates
Prize pool breakdown
Total prize
60,000 USDC
nSLOC
2,87821 USDC / LOC
50,000 USDC
5,500 USDC
4,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.