Submission Details
Severity:
Some functions has pure modifier although they access the storage pointer.
Summary
Some functions has pure modifier although they access the storage pointer.
Vulnerability Details
Some functions are marked as pure, indicating that it does not read or modify the contract's state, but they use inline assembly to manipulate storage, which contradicts the pure modifier.
For instance, MarketOrder.load() function is the following.
function load(uint128 tradingAccountId) internal pure returns (Data storage self) {
bytes32 slot = keccak256(abi.encode(MARKET_ORDER_LOCATION, tradingAccountId));
assembly {
self.slot := slot
}
}
Tens of other functions have the same problems.
Impact
It may cause misunderstanding and errors during maintenance.
Tools Used
Manual Review
Recommendations
Remove pure modifier and add view modifier to the functions.
Prize pool breakdown
Total prize
60,000 USDC
nSLOC
2,87821 USDC / LOC
50,000 USDC
5,500 USDC
4,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.