Zaros Part 1

Relevant GitHub Links

https://github.com/Cyfrin/2024-07-zaros/blob/main/src/perpetuals/branches/LiquidationBranch.sol#L42-L86

Summary

The array initialization in checkLiquidatableAccounts leads to inefficiencies by potentially allocating more memory than necessary.

Vulnerability Details

The array liquidatableAccountsIds is initialized with a size based on the upper and lower bounds of the iteration, which might be larger than the actual number of liquidatable accounts, leading to inefficient memory usage and increased gas costs.

Impact

• Increased Gas Costs: Unnecessary allocation of memory increases gas consumption.

• Inefficiency: Potential waste of resources due to oversized array initialization.

Tools Used

Manual

Recommendations

Optimize Array Initialization: Initialize the array to the exact number of liquidatable accounts found.