Submission Details
Severity:
priceFeedHeartbeatSeconds can't be updated
Description
The update function in MarketConfiguration.sol does not update priceFeedHeartbeatSeconds parameter of the market
/// @notice Updates the given market configuration.
/// @dev See {MarketConfiguration.Data} for parameter details.
function update(Data storage self, Data memory params) internal {
self.name = params.name;
self.symbol = params.symbol;
self.priceAdapter = params.priceAdapter;
self.initialMarginRateX18 = params.initialMarginRateX18;
self.maintenanceMarginRateX18 = params.maintenanceMarginRateX18;
self.maxOpenInterest = params.maxOpenInterest;
self.maxSkew = params.maxSkew;
self.maxFundingVelocity = params.maxFundingVelocity;
self.minTradeSizeX18 = params.minTradeSizeX18;
self.skewScale = params.skewScale;
self.orderFees = params.orderFees;
}
Impact
The updatePerpMarketConfiguration in GlobalConfigurationBranch.sol does not work as expected and will give the false expectation that it updates market parameters as expected when in reality priceFeedHeartbeatSeconds is not updated, this can lead to various issues with oracle down the line.
Updates
Lead Judging Commences
inallhonesty about 1 year ago
Submission Judgement Published Assigned finding tags:
`MarketConfiguration::update` function lacks `priceFeedHeartbeatSeconds` argument
Prize pool breakdown
Total prize
60,000 USDC
nSLOC
2,87821 USDC / LOC
50,000 USDC
5,500 USDC
4,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.