Zaros Part 1
Zaros
DeFiFoundry
60,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

Array of unlimited size passed to `GlobalConfigurationBranch::configureCollateralLiquidationPriority` function may cause a DOS

0xrolko

Relevant GitHub Links

https://github.com/Cyfrin/2024-07-zaros/blob/d687fe96bb7ace8652778797052a38763fbcbb1b/src/perpetuals/branches/GlobalConfigurationBranch.sol#L205

Vulnerability Details

@> function configureCollateralLiquidationPriority(address[] calldata collateralTypes) external onlyOwner {
if (collateralTypes.length == 0) {
revert Errors.ZeroInput("collateralTypes");
}
​
GlobalConfiguration.Data storage globalConfiguration = GlobalConfiguration.load();
globalConfiguration.configureCollateralLiquidationPriority(collateralTypes);
​
emit LogConfigureCollateralLiquidationPriority(msg.sender, collateralTypes);
}

Impact

DOS blocking the use of the GlobalConfigurationBranch::configureCollateralLiquidationPriority function

Tools Used

Manual review

Recommendations

Specify the maximum size of the `collateralTypes` array.

Updates

Lead Judging Commences

inallhonesty Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.