Zaros Part 1
Zaros
DeFiFoundry
60,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

Hearbeat is incorrect for `BTC/USD` and `ETH/USD` pricefeed, can return inconsistent data

unRekt

Summary

Hearbeat is incorrect for BTC/USD and ETH/USD pricefeed on Arbitrum mainnet

Vulnerability Details

As per the Chainlink data feed the recommended heartbeat for

  • BTC/USD : 24 hours here

  • ETH/USD : 24 hours here

But the heartbeat used in the protocol is

  • ETH_USD_PRICE_FEED_HEARTBEATS_SECONDS : 120

  • BTC_USD_PRICE_FEED_HEARTBEATS_SECONDS : 3600

https://github.com/Cyfrin/2024-07-zaros/blob/d687fe96bb7ace8652778797052a38763fbcbb1b/script/markets/BtcUsd.sol#L30

https://github.com/Cyfrin/2024-07-zaros/blob/d687fe96bb7ace8652778797052a38763fbcbb1b/script/markets/EthUsd.sol#L30

Impact

Using heartbeat less than required can return inconsistent data

Tools Used

Recommendations

Use correct recommended heartbeat for price feeds.

Updates

Lead Judging Commences

inallhonesty Lead Judge 11 months ago
Submission Judgement Published
Invalidated
Reason: Out of scope

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.