Zaros Part 1
Zaros
DeFiFoundry
60,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

Missing input validation check , `0` value can be used as input which is not desired.

unRekt

Summary

Missing input validation

Vulnerability Details

The function configureSystemParameters in GlobalConfigurationBranch lacks input validation for marketOrderMinLifetime parameter. It checks for all the other parameters of the function but misses to check marketOrderMinLifetime

https://github.com/Cyfrin/2024-07-zaros/blob/d687fe96bb7ace8652778797052a38763fbcbb1b/src/perpetuals/branches/GlobalConfigurationBranch.sol#L286-L341

Impact

0 value can be used as input which is not desired.

Tools Used

Manual review

Recommended Mitigation

Implement check for 0 value
E.g.

if (marketOrderMinLifetime== 0) {
revert Errors.ZeroInput("marketOrderMinLifetime");
}
Updates

Lead Judging Commences

inallhonesty Lead Judge 11 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.