Zaros Part 1
Zaros
DeFiFoundry
60,000 USDC
View results
Previous Next
Submission Details
Severity: medium
Valid

Not updating `priceFeedHeartbeatSeconds ` in `MarketConfiguration`

unRekt

Summary

Not updating priceFeedHeartbeatSeconds in update function

Vulnerability Details

All the parameters of the struct Data is updated in the update function, but priceFeedHeartbeatSeconds is not updated.

https://github.com/Cyfrin/2024-07-zaros/blob/d687fe96bb7ace8652778797052a38763fbcbb1b/src/perpetuals/leaves/MarketConfiguration.sol#L32

https://github.com/Cyfrin/2024-07-zaros/blob/d687fe96bb7ace8652778797052a38763fbcbb1b/src/perpetuals/leaves/MarketConfiguration.sol#L37-L49

Impact

It might return stale data

Tools Used

Manual review

Recommended Mitigation

Update priceFeedHeartbeatSeconds in the update function

Updates

Lead Judging Commences

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

`MarketConfiguration::update` function lacks `priceFeedHeartbeatSeconds` argument

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.