Submission Details
Severity:
getAccountEquityUsd does take open position into account, in contradiction with the function's NatSpec description.
Vulnerability Details
The function TradingAccount::getAccountEquityUsd has the following comment:
/// @dev This function doesn't take open positions into account.
However, the function returns the user's total collateral + the unrealized PnL of his active positions. Clearly, it is also taking open positions into account, as that is where the unrealized PnL comes from.
Impact
No clear impact, but NatSpec is part of the protocol documentation, so there should be no mistakes there, so that users and developers are not misled.
Tools Used
Manual Review
Recommendations
Make sure the comments are consistent with the implementation.
Prize pool breakdown
Total prize
60,000 USDC
nSLOC
2,87821 USDC / LOC
50,000 USDC
5,500 USDC
4,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.