Summary

If too many offchain orders are created by users, keeper can be DOSsed and run out of gas when attempting to fill them. This can be done intentionally with malicious intent or happen during normal operation.

Vulnerability Details

The system provides a means for users to sign offchain orders which are broadcasted to the network and the keeper is called to fill these orders.

According to the function NatSpec,the keeper fills pending offchain orders for a given market. Therefore we can assume the keeper would attempt to fill all active offchain orders. An attacker can sign dozens or hundreds of offchain orders with negligible position changes, causing the keeper to attempt to fill them all. Here, either the keeper runs out of gas when attempting to fill these orders or other users legitimate offchain orders would be delayed significantly. Either way legitimate users can be griefed.

Impact

Filling of offchain orders by the keepers can be caused to fail, causing grief to users and protocol.

Tools Used

Manual Review

Recommendations

No clear mitigation at this moment