Zaros Part 1
Zaros
DeFiFoundry
60,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

`createPerpMarket` function is not checking `initialMarginRateX18` for `0` input validation

unRekt

Summary

createPerpMarket function is not checking initialMarginRateX18 for 0 input validation

Vulnerability Details

initialMarginRateX18 can be set to 0 because no input validation is done in createPerpMarket function.
But the function updatePerpMarketConfiguration function is doing 0 input validation check for initialMarginRateX18

https://github.com/Cyfrin/2024-07-zaros/blob/main/src/perpetuals/branches/GlobalConfigurationBranch.sol#L401
https://github.com/Cyfrin/2024-07-zaros/blob/main/src/perpetuals/branches/GlobalConfigurationBranch.sol#L505

Impact

Owner can set initialMarginRateX18 to 0 by mistake which is not desirable

Tools Used

Manual review

Recommended Mitigation

Use this if statement in createPerpMarket :

if (params.initialMarginRateX18 == 0) {
revert Errors.ZeroInput("initialMarginRateX18")
Updates

Lead Judging Commences

inallhonesty Lead Judge
about 1 year ago
inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.